Ian,
Sounds to me like something has happened to turn you around. I hope it was nothing personal, to you or yours. There are plenty of bad things happening in this world, and I wouldn't wish them on anyone.
But I agree, in principal, with your comments. Criminal DO need to be held accountable for their crimes, and for the pain and suffering, both physical and emotional, that they have caused their victims, which includes the families of those who were actually harmed. The work camps which you describe, however, seem more like concentration camps or gulags than prisons. A far more effective punishment would be keeping them in confinement, with little to do but think about why they are there.
It's my opinion that convicted criminals should have almost all of their rights rescinded, except for certain basic rights. Adequate food, of course, to maintain their physical health, as well as BASIC healthcare when required. Mental health care, in appropriate institutions, for those so in need. Other PRIVILEGES may be earned, perhaps, through good behavior, including the option of performing some kind of useful labor. I don't claim that modern prisons are nice places, but when prisoners are given cable television and internet access, or access to unnecessary medical procedures (such as the sex change operation you mentioned) then something is seriously wrong.
And I still maintain that some people, the very worst, most incorrigible criminals, should be subject to the possibility of the death sentence. Not as a deterrent to others, as I don't think that kind of person would be deterred by another person's suffering. But simply to insure that, no matter what happens, no matter which political party is in power, that person will never, ever be released into society again. And death is the only sure guarantee.
While a certain part of a criminal's punishment is intended to help ease the pain and fear of the victims, the primary purpose of the justice system is, in my opinion, to protect society from such criminals. In some cases prison will do that. Few will want to risk returning to prison after being released. But some people are so defective, so evil, they should not, EVER, be allowed to interact with others again. Killing them may not make their victims feel any better, but knowing that they will never threaten anyone ever again makes ME feel better.